Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with typescript-eslint 8 #151

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

alecmev
Copy link
Contributor

@alecmev alecmev commented Aug 15, 2024

typeParameters has been deprecated and replaced by typeArguments in v6, and finally removed in v8. This makes v6 the minimum version, so it's a breaking change.

`typeParameters` has been deprecated and replaced by `typeArguments` in
v6, and finally removed in v8.
@facebook-github-bot
Copy link

Hi @alecmev!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@captbaritone
Copy link
Contributor

Thanks for the PR!

Looks like this breaks some of our CI runs. Would you mind updating https://github.com/relayjs/eslint-plugin-relay/blob/main/.github/workflows/ci.yml to remove incompatible node versions (and maybe add some newer ones?)

jsxBracketSameLine is deprecated in favor of bracketSameLine.
@alecmev
Copy link
Contributor Author

alecmev commented Aug 18, 2024

@captbaritone Sure, done!

@captbaritone captbaritone merged commit 24fd162 into relayjs:main Aug 27, 2024
6 checks passed
@alecmev alecmev deleted the tseslint-8 branch August 27, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants