Add builtins and proofs for the Merkle example #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpenciak
force-pushed
the
mp/field_builtins
branch
from
747876a to
8eb0223
Compare
mpenciak
changed the title
iamrecursion
changed the title
iamrecursion
force-pushed
the
mp/field_builtins
branch
2 times, most recently
from
468a582 to
ffb7706
Compare
This commit also provides `to_array_spec` which is not the same as the `to_array_inv` that it removes. The postcondition is _far_ simpler, and it requires far fewer input constraints to make it work. It should still suffice, however.
* remove redudant `exact ()` and `trivial`s * verify BE and LE decompositions * move lemmas to Ext module and remove least useful ones * simplify simps and fix formatting * applyRangeConstraint builtin + bn254 proofs + from le/be * initial unyieldy proof for pow32 * simplify pow_32 intro * remove map_toFin_map_ofFin * generalize mod_u32_sub_add_eq to mod_sub_add_eq * document empty postconditions being required for steps * reorder bits & bytes results more logically
Eduardogbg
force-pushed
the
mp/field_builtins
branch
from
5876c4f to
2a096aa
Compare
Eduardogbg
reviewed
Jan 14, 2026
Collaborator
Eduardogbg
left a comment
Eduardogbg
left a comment
There was a problem hiding this comment.
I guess changes mostly fall into the following categories:
- changes from my branch (which we already reviewed)
- removal of big int (which I have no context for but i assume is related to making lampe match noir more closely)
- builtin changes (some of which I did some of which i didn't)
i made comments about the ones i have questions about
Lampe/Lampe/Builtin/Helpers.lean
Outdated
| _ = _ := by simp [Nat.pow_succ, Nat.mul_comm] | ||
| ⟩ | ||
|
|
||
| -- def ofDigitsBE {d} (v : List.Vector (Digit r) d): RadixVec r d := match d with |
| -- · exact Fin.prop _ | ||
| -- ⟩ | ||
|
|
||
| def ofDigitsBE' (l : List (Digit r)): Nat := |
Collaborator
There was a problem hiding this comment.
are we ok with this naming convention with '?
Lampe/Lampe/Builtin/Helpers.lean
Outdated
| -- := lst ++ (List.replicate (len - lst.length) default) | ||
|
|
||
| -- @[reducible] | ||
| -- def decomposeToRadix (r : Nat) (v : Nat) (h : r > 1) : List Nat := match v with |
Collaborator
There was a problem hiding this comment.
this seems interesting? I guess we could have used this for the semantics? what's your opinion @kustosz
Eduardogbg
force-pushed
the
mp/field_builtins
branch
from
e496b3b to
cd8b2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.