Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed tempfile naming, added some debugging and fixed a typo #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

magenbrot
Copy link
Contributor

Hi @regilero,

I've had a problem while using your check. The temporary file was created with the hostname given as argument. This leads to problems when you have more than one PHP-FPM pool, since all data was written to the same file when using multiple checks.

I've changed the $TempFile variable to use the $Pool from the status page result.

Additionally I added some more debugging and fixed a typo.

@regilero regilero added the Bug label Jun 7, 2019
@regilero
Copy link
Owner

regilero commented Jun 7, 2019

Hello, that's effectively a problem. Thanks for writing a fix.
But from what I can read on your patch you replace this problem by another one, what about multiple servers having the same pool name?
Could you rewrite your fix and alter the temporary filename by adding both the pool name and the host name? Then you could also add a a line with your name in the CHANGELOG, and a quick issue description.

@magenbrot
Copy link
Contributor Author

you're right. I'll change that

* bumped version to 1.2
* updating CHANGELOG and README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants