Added support for connecting to an UNIX socket #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'll need to test that, but at first impression it seems good. Thanks. Hope I can take some time soon to review it more deeply. |
tackerm
reviewed
Jul 4, 2019
check_phpfpm_status.pl
Outdated
| @@ -107,6 +108,8 @@ sub help { | |||
| ServerName, (host header of HTTP request) use it if you specified an IP in -H to match the good Virtualhost in your target | |||
| -f, --fastcgi | |||
| Connect directly to php-fpm via network or local socket, using fastcgi protocol instead of HTTP. | |||
| -u, --unixsocket | |||
There was a problem hiding this comment.
The -u option is already used as a shortcut for --url. My perl is a bit rusty, but it looks like there is no short form for the --unixsocket option at all?
There was a problem hiding this comment.
thx, you are right. The problem is that the most useful short forms are already in use (-u -U -s -S). I'm considering to give --unixsocket no short form (like --verifyssl). Someone else having an idea? :)
There was a problem hiding this comment.
Personally, I am happy with the long form - it's an icinga plugin, so not something we need to type regularly :)
* fix indention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @regilero!
Here's a merge request that adds support for UNIX sockets.
Notes: when --unixsocket is used, -f --fastcgi is implied