Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the TypedUseQueryStateOptions helper type #4604

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

aryaemami59
Copy link
Contributor

@aryaemami59 aryaemami59 commented Sep 4, 2024

This PR:

  • Adds TypedUseQueryStateOptions helper type which Provides a way to define a "pre-typed" version of UseQueryStateOptions.
  • Marks the UseQueryStateOptions type with an @internal JSDoc tag.
  • Marks the SubscriptionOptions type with a @public JSDoc tag.
  • Adds type tests for TypedUseQueryStateOptions.
  • Resolves Rtk query is not exporting useQuery options types #4600.

Copy link

codesandbox bot commented Sep 4, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Sep 4, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e569971:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit e569971
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/66f00b9b47dac4000844dc71
😎 Deploy Preview https://deploy-preview-4604--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EskiMojo14
Copy link
Collaborator

EskiMojo14 commented Sep 11, 2024

can we export a Typed version instead which accepts friendlier arguments, like the other helpers?

@aryaemami59
Copy link
Contributor Author

@EskiMojo14 Yeah that sounds like a great idea.

@aryaemami59 aryaemami59 changed the title Export the UseQueryStateOptions type Add the TypedUseQueryStateOptions helper type Sep 11, 2024
@aryaemami59 aryaemami59 force-pushed the export-UseQueryStateOptions branch 4 times, most recently from 1bc3b3d to c42acfa Compare September 13, 2024 22:37
@EskiMojo14 EskiMojo14 merged commit c8f3739 into reduxjs:master Sep 24, 2024
43 checks passed
@EskiMojo14
Copy link
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rtk query is not exporting useQuery options types
2 participants