storage: add log lines about removed data #24659
Open
+91
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some accounting to the copy_data_segment_reducer to keep track of records and batches that are removed. The goal here is ultimately to provide more visibility into removed records, though this accounting isn't yet plugged into anything. A later change will expose numbers (likely with logging).
Removing records from the storage layer is currently very silent, making it difficult to debug. This commit exposes the new copy_data_segment_reducer stats in as a log message, at info level when data is removed, and debug level when not (presumably we mostly care about these stats when data is actually being removed).
CI test resultstest results on build#60138
|
WillemKauf
reviewed
Dec 29, 2024
| const auto& stats = res.reducer_stats; | ||
| if (stats.has_removed_data()) { | ||
| vlog( | ||
| gclog.info, |
There was a problem hiding this comment.
I don't have strong feelings that this shouldn't be at the info level, but I can imagine that it would make compaction output for a log with a high number of segments much noisier.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very difficult to retroactively debug why records are removed by compaction. This adds some logging about removed data.
Backports Required
Release Notes
Improvements