ducktape: Respect rpk timeout in rpk #24642
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass the timeout value for rpk that is passed to subprocess also to rpk itself via `request_timeout_overhead`. Otherwise the specified timeout will not really be respected if the default timeout in rpk for a certain command is shorter. Because `request_timeout_overhead` is on top of other possible timeouts the total timeout might be larger than the subprocess one but that should be fine.
|
All CDT failure are known |
travisdowns
reviewed
Jan 2, 2025
| @@ -71,8 +71,7 @@ def test_modify_then_query_error(self): | |||
| FailureSpec(FailureSpec.FAILURE_ISOLATE, | |||
| self.redpanda.controller())) | |||
|
|
|||
| # Timeout must be larger then hardcoded timeout of 5s within redpanda | |||
| _ = superclient.acl_list(request_timeout_overhead=30) | |||
| _ = superclient.acl_list() | |||
There was a problem hiding this comment.
Won't this set this test back to 5s timeout, which may cause it to fail?
There was a problem hiding this comment.
I.e., don't we need to set timeout on the rpk object to 30s now in this test.
There was a problem hiding this comment.
No not really because the default timeout is 30s anyway and the request_timeout_overhead thing now effectively applies to everything so the special casing in acl_list isn't needed anymore.
CI test resultstest results on build#60219
|
travisdowns
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the timeout value for rpk that is passed to subprocess also to rpk
itself via
request_timeout_overhead.Otherwise the specified timeout will not really be respected if the
default timeout in rpk for a certain command is shorter.
Because
request_timeout_overheadis on top of other possible timeoutsthe total timeout might be larger than the subprocess one but that
should be fine.
Backports Required
Release Notes