snowpipe: fix cleanup

redpanda-data · Dec 9, 2024 · e5423ce · e5423ce
1 parent b71475a
commit e5423ce
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/impl/snowflake/output_snowflake_streaming.go b/internal/impl/snowflake/output_snowflake_streaming.go
@@ -583,7 +583,6 @@ const SnowflakeClientResourceForTesting snowflakeClientForTesting = "SnowflakeCl
 
 type snowpipeStreamingOutput struct {
 	initStatementsFn func(context.Context, *streaming.SnowflakeRestClient) error
-	client           *streaming.SnowflakeServiceClient
 	restClient       *streaming.SnowflakeRestClient
 	mapping          *bloblang.Executor
 	logger           *service.Logger
@@ -695,7 +694,6 @@ func (o *snowpipeStreamingOutput) Close(ctx context.Context) error {
 		return err
 	}
 	o.restClient.Close()
-	o.client.Close()
 	return nil
 }
 
@@ -785,6 +783,7 @@ func (o *snowpipePooledOutput) WriteBatch(ctx context.Context, batch service.Mes
 
 func (o *snowpipePooledOutput) Close(ctx context.Context) error {
 	o.channelPool.Reset()
+	o.client.Close()
 	return nil
 }
 
@@ -872,6 +871,7 @@ func (o *snowpipeIndexedOutput) WriteBatch(ctx context.Context, batch service.Me
 
 func (o *snowpipeIndexedOutput) Close(ctx context.Context) error {
 	o.channelPool.Reset()
+	o.client.Close()
 	return nil
 }