Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify volume in player #289

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

justusmattern27
Copy link
Member

This addresses #282

Copy link
Member

@hkonsti hkonsti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -64,6 +66,7 @@ export function Player({
const [playingState, setPlaying] = useState(playing);
const [isMouseOver, setIsMouseOver] = useState(false);
const [currentTimeState, setCurrentTime] = useState(currentTime);
const [volumeState, setVolumeState] = useState(volume); // Add this line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLM comment haha

@justusmattern27 justusmattern27 merged commit c83cc72 into main Sep 22, 2024
9 checks passed
@justusmattern27 justusmattern27 deleted the justus/player-adjust-volume branch September 23, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants