Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async CredentialProvider #3423

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yulin-li
Copy link

@yulin-li yulin-li commented Nov 4, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

This a draft PR to explain #3422

The PR introduces breaking changes and we may need to update it to make it backward compatible.

@yulin-li yulin-li marked this pull request as ready for review November 27, 2024 03:54
@vladvildanov
Copy link
Collaborator

@yulin-li I suggest to extend an existing interface with smth like get_credentials_async() to make it backward compatible. I'm planning to do this as a part of #3423

@yulin-li
Copy link
Author

yulin-li commented Dec 6, 2024

that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants