Skip to content

Conversation

@DevineLiu
Copy link

We should have a means to reclaim the sentinels' connection resources established by NewFailoverClusterClient.

@monkey92t
Copy link
Collaborator

I didn't understand this PR. What does it mean?

@DevineLiu
Copy link
Author

When using NewFailoverClusterClient for initialization, at line 788, the code initializes connections to the Sentinels, and at line 792, the client subscribes to the Sentinel. However, the long-lived connection between the client and the Sentinel doesn't get closed when Close is called on the ClusterClient returned by NewFailoverClient.

This issue occurs when the Close method is called on ClusterClient, and the long-lived connection to the Sentinel is not closed along with it.

@DevineLiu DevineLiu changed the title Attempt to Close Sentinel when the cluster is Closed. Attempt to Close Sentinel when the NewFailoverClusterClient is Closed. Apr 16, 2024
@ndyakov
Copy link
Member

ndyakov commented May 7, 2025

@DevineLiu I think this is handled in the latest version, please review and if needed open separate PR.

@ndyakov ndyakov closed this May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants