Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RC: RDI in the cloud #570

Draft
wants to merge 54 commits into
base: main
Choose a base branch
from
Draft

RC: RDI in the cloud #570

wants to merge 54 commits into from

Conversation

kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael commented Aug 19, 2024 •
edited by cmilesb
Loading

@kaitlynmichael kaitlynmichael self-assigned this Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/setup
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/setup
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/setup
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/setup
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/define
https://redis.io/docs/staging/DOC-4137/operate/rc/databases/rdi/view-edit

andy-stark-redis
andy-stark-redis requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of possible suggestions, but there are also some gltiches that need attention. Otherwise, looking great so far :-)

content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/_index.md Outdated Show resolved Hide resolved
@cmilesb cmilesb self-assigned this Aug 29, 2024
@cmilesb cmilesb requested a review from yaronp68 September 13, 2024 20:46
andy-stark-redis
andy-stark-redis requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things (broken link does need fixing, though) but otherwise looking really good :-)

content/operate/rc/databases/rdi/define.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/define.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/provision.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/provision.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/setup.md Show resolved Hide resolved
content/operate/rc/databases/rdi/view-edit.md Outdated Show resolved Hide resolved
andy-stark-redis
andy-stark-redis reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One place where a link might not be right but otherwise looks good. I think there are still screenshots and other stuff still to add, so possibly too early to give final approval for the PR.

content/operate/rc/databases/rdi/define.md Outdated Show resolved Hide resolved
andy-stark-redis
andy-stark-redis approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe one or two minor suggestions, but otherwise LGTM.

content/operate/rc/databases/rdi/define.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/view-edit.md Outdated Show resolved Hide resolved
content/operate/rc/databases/rdi/view-edit.md Outdated Show resolved Hide resolved
andy-stark-redis
andy-stark-redis approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, but otherwise looking really good :-)

content/operate/rc/databases/rdi/view-edit.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmilesb cmilesb cmilesb left review comments

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

@joniredis joniredis Awaiting requested review from joniredis

@yaronp68 yaronp68 Awaiting requested review from yaronp68

@mich-elle-luna mich-elle-luna Awaiting requested review from mich-elle-luna

Requested changes must be addressed to merge this pull request.

Assignees

@cmilesb cmilesb

Labels
do not merge yet rc Redis Cloud docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kaitlynmichael @CLAassistant @yaronp68 @joniredis @cmilesb @andy-stark-redis