-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use categories to identify products on each content page #270
Conversation
@mich-elle-luna Great idea to add category info to the page and I think having it right under the brief description line is the ideal position :-) Just a few thoughts about this:
|
Ok @andy-stark-redis I worked on the styling, let me know if this looks good to you or if you have more feedback. I think I will wait to add linking and the categories list/index pages in a separate PR because this first part could actually help people already. But, I will work on that part next. Thanks! |
@mich-elle-luna I'd say that's looking quite nice now :-) Using a table with rounded ends but straight dividers between categories looks really neat. The only thing I would note is that the categories appear on almost all of the appropriate pages but not absolutely all (eg, Redis Insight landing page). This is because the category metadata isn't in these pages, and not down to a layout issue. However, if we introduce these categories then I would say we really need to check they appear everywhere they should. As with the links, this probably needs a separate PR to check for missing metadata and fix it. Also, I'm wondering if there's a way to automate checking/suggesting categories in all the docs based on keywords or something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this one back again ;-) LGTM
This PR adds a table at the top of every page with a category column that is color coded for the applicable products. Let me know what you think.
https://redis.io/docs/staging/categories/operate/
https://redis.io/docs/staging/categories/operate/oss_and_stack/install/install-redis/install-redis-from-source/