-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp tests #350
Merged
Merged
Revamp tests #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uglide
commented
Nov 29, 2024
- Use endpoints.json instead of hardcoded configs
- Use client-libs-test image
- Add run-tests action
- Use [Theory] based approach to run tests against multiple endpoints
- Remove old config and env files
uglide
force-pushed
the
revamp_tests
branch
2 times, most recently
from
November 29, 2024 15:19
a60ad3e
to
0f6c630
Compare
uglide
force-pushed
the
revamp_tests
branch
2 times, most recently
from
January 13, 2025 15:36
f14b0a3
to
78f1d22
Compare
- Use endpoints.json instead of hardcoded configs - Use client-libs-test image - Add run-tests action - Use [Theory] based approach to run tests against multiple endpoints - Remove old config and env files - Use stack-based images - Use xunit.skippablefact
atakavci
reviewed
Jan 22, 2025
atakavci
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.