Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mirror_images] allow to set the image registry org #528

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[mirror_images] allow to set the image registry org #528

wants to merge 3 commits into from
+9 −2

Conversation

manurodriguez
Copy link
Contributor

@manurodriguez manurodriguez commented Jan 13, 2025 •
edited
Loading

SUMMARY

This change allows to define the target image registry organization if defined in variable mi_dst_org, otherwise the default in the src registry will be used.

ISSUE TYPE

Minor Enhanced Feature

Tests

Test-Hint: no-check

@manurodriguez
[mirror_images] allow to set the image registry org
8c98d85 
This change allows to define the target image registry
organization if defined in variable mi_dst_org, otherwise
the default in the src registry will be used.
@manurodriguez manurodriguez self-assigned this Jan 13, 2025
@manurodriguez manurodriguez requested a review from a team as a code owner January 13, 2025 21:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a2eda5edbe514ea085f13620ddb33524

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 07s

@dcibot
Copy link
Collaborator

dcibot commented Jan 13, 2025

from change #528:

@manurodriguez
Copy link
Contributor Author

retest

@dcibot
Copy link
Collaborator

dcibot commented Jan 14, 2025

from change #528:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/efcc11912d5e4bb5b01ca79f431e44f1

✔️ dci-rpm-build-el8 SUCCESS in 2m 45s
✔️ dci-rpm-build-el9 SUCCESS in 2m 48s

@dcibot
Copy link
Collaborator

dcibot commented Jan 14, 2025

from change #528:

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/676b6a79ca084f858e889dd775394117

✔️ dci-rpm-build-el8 SUCCESS in 2m 44s
✔️ dci-rpm-build-el9 SUCCESS in 2m 40s

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change #528:

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change #528:

tonyskapunk
tonyskapunk approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@tonyskapunk tonyskapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this needed improvement!!

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

@dcibot
Copy link
Collaborator

dcibot commented Jan 15, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

@dcibot
Copy link
Collaborator

dcibot commented Jan 16, 2025

from change https://github.com/dci-labs/f5-spk-config/pull/224:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betoredhat betoredhat betoredhat left review comments

@tonyskapunk tonyskapunk tonyskapunk approved these changes

Assignees

@manurodriguez manurodriguez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manurodriguez @dcibot @tonyskapunk @betoredhat