Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more bicep content to actually deploy ARO on Azure #17

Merged
merged 28 commits into from
Aug 14, 2024

Conversation

kksat
Copy link
Collaborator

@kksat kksat commented Aug 13, 2024

No description provided.

kksat added 28 commits August 13, 2024 09:52
Signed-off-by: kksat <[email protected]>
Signed-off-by: kksat <[email protected]>
there are additional authorization that are required for this SP

Signed-off-by: kksat <[email protected]>
so they are displayed in `make help` command

Signed-off-by: kksat <[email protected]>
Signed-off-by: kksat <[email protected]>
to remove unnecessary output

Signed-off-by: kksat <[email protected]>
additional check before ARO deployment

Signed-off-by: kksat <[email protected]>
Signed-off-by: kksat <[email protected]>
bicep.makefile Show resolved Hide resolved
Copy link
Contributor

@mjiao mjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hack/domain-records.sh Show resolved Hide resolved
@mjiao mjiao merged commit b7a54fa into redhat-sap:main Aug 14, 2024
3 checks passed
@kksat kksat deleted the bicep-aro2 branch September 25, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants