Allow dynamic instances of non-hotplug plugins #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off #628 for easier review and discussion.
This removes the checks for "is the plugin of type
hotplug.Plugin
" frominstance_create
andinstance_destroy
, while keeping the rest of the code in controller.py as-is. To do this, some of the device related methods need noop-implementations inbase.Plugin
.Notes:
base.Plugin
seems to implement some device methods with actual logic (assign_free_devices
,release_devices
,_run_for_each_device
,_call_device_script
,_*_device_commands
). Why are those not inhotplug.Plugin
?create_instance
, we could add checking and warnings if the user creates abase.Plugin
instance and sets thedevices=
ordevices_udev_regex=
options. At the moment these options would be ignored silently (which is also ok I guess).