fix: forward _all_ LSP telemetry events#4188
Closed
fbricon wants to merge 1 commit intoredhat-developer:mainfrom
Closed
fix: forward _all_ LSP telemetry events#4188fbricon wants to merge 1 commit intoredhat-developer:mainfrom
fbricon wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: Fred Bricon <fbricon@gmail.com>
Collaborator
Author
|
After thinking about it, I think the downside of this PR is it would include potential crap a rogue jdt.ls extension could send. |
Collaborator
Author
|
OK, after discussing with @rgrunber, we decided it's safer for vscode-java to explicitly control what goes in our telemetry pipeline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only "java.workspace.initialized" and "java.ls.error" events are sent.
Either we keep whitelisting events, but then new stuff like potentially eclipse-jdtls/eclipse.jdt.ls#3544 need to add new events to the whitelist, or we trust all JDT.LS events to be forwarded to our telemetry backend.