Skip to content

Update prerequisite instructions to work across distributions #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlwgeorge wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update prerequisite instructions to work across distributions #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions source/prerequisites.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,19 @@ explicitly to show which tools are used in this guide.
endif::rhel[]

ifdef::community[]
On Fedora, CentOS 8, and RHEL 8:
On Fedora, CentOS Stream 9, and RHEL 9:

[source,bash]
----
$ dnf install gcc rpm-build rpm-devel rpmlint make python bash coreutils diffutils patch rpmdevtools
$ dnf install gcc rpm-build rpm-devel rpmlint make python3 bash coreutils diffutils patch rpmdevtools
----

On CentOS Stream 8 and RHEL 8:

[source,bash]
----
$ dnf install gcc rpm-build rpm-devel rpmlint make python3 bash coreutils diffutils patch rpmdevtools
Copy link
Collaborator

@xsuchy xsuchy Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are using python3 on rhel8 and python on rhel9. It should be the other way round, isn't it? The same in the other part bellow.

Copy link
Contributor Author

@carlwgeorge carlwgeorge Aug 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnf install python works on rhel9, because python-unversioned-command provides python. I can adjust this to the actual package name if you like, it just makes the command longer for no real benefit. Since the current instructions do not work on rhel8, I was trying to change as little as possible from the previous instructions but still get things working. Longer term I'd like to send another pull request to switch the guide over to python3, which would simplify the instructions.

Copy link
Contributor Author

@carlwgeorge carlwgeorge Apr 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use python3 on both rhel8 and rhel9.

$ alternatives --set python /usr/bin/python3
----

On CentOS 7 and RHEL 7:
Expand All @@ -33,6 +41,21 @@ $ yum install gcc rpm-build rpm-devel rpmlint make python bash coreutils diffuti
endif::community[]

ifdef::rhel[]
On RHEL 9:

[source,bash]
----
$ dnf install gcc rpm-build rpm-devel rpmlint make python3 bash coreutils diffutils patch rpmdevtools
----

On RHEL 8:
[source,bash]
----
$ dnf install gcc rpm-build rpm-devel rpmlint make python3 bash coreutils diffutils patch rpmdevtools
$ alternatives --set python /usr/bin/python3
----

On RHEL 7:
[source,bash]
----
$ yum install gcc rpm-build rpm-devel rpmlint make python bash coreutils diffutils patch rpmdevtools
Expand Down