-
Notifications
You must be signed in to change notification settings - Fork 199
chore(e2e): configure ESLint to Playwright recommended #3349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ce6552
to
9e7c066
Compare
/test e2e-tests |
1 similar comment
/test e2e-tests |
9e7c066
to
bf5869e
Compare
/test e2e-tests-eks-helm-nightly |
/test e2e-tests |
Assisted-by: Cursor
@zdrapela: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
e025969
to
78c28b3
Compare
/test e2e-tests |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gustavolira The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Configure ESlint for e2e tests to align with the recommended settings: https://playwright.dev/docs/best-practices#lint-your-tests and https://github.com/playwright-community/eslint-plugin-playwright plugin
This helps both humans and AI coding tools to produce better code aligned with Playwright best practices.
Update the tests to fix the new linter errors and warnings.
Update ESLint and enforce file and folder names in kebab-case.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer