Skip to content

Conversation

zdrapela
Copy link
Member

@zdrapela zdrapela commented Sep 1, 2025

Description

Configure ESlint for e2e tests to align with the recommended settings: https://playwright.dev/docs/best-practices#lint-your-tests and https://github.com/playwright-community/eslint-plugin-playwright plugin
This helps both humans and AI coding tools to produce better code aligned with Playwright best practices.

Update the tests to fix the new linter errors and warnings.

Update ESLint and enforce file and folder names in kebab-case.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from gustavolira and psrna September 1, 2025 11:46
@zdrapela zdrapela changed the title chore(e2e): configure ESlint to Playwright recommended chore(e2e): configure ESLint to Playwright recommended Sep 1, 2025
@zdrapela
Copy link
Member Author

zdrapela commented Sep 1, 2025

/test e2e-tests

1 similar comment
@zdrapela
Copy link
Member Author

zdrapela commented Sep 2, 2025

/test e2e-tests

@zdrapela
Copy link
Member Author

zdrapela commented Sep 3, 2025

/test e2e-tests-eks-helm-nightly

@zdrapela
Copy link
Member Author

zdrapela commented Sep 3, 2025

/test e2e-tests

Copy link

openshift-ci bot commented Sep 3, 2025

@zdrapela: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests-eks-helm-nightly 5c7acf1 link false /test e2e-tests-eks-helm-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zdrapela
Copy link
Member Author

zdrapela commented Sep 3, 2025

/test e2e-tests

@openshift-ci openshift-ci bot added the approved label Sep 4, 2025
@gustavolira
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavolira

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdrapela zdrapela merged commit 62e207b into redhat-developer:main Sep 4, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants