Skip to content

Conversation

christoph-jerolimov
Copy link
Member

@christoph-jerolimov christoph-jerolimov commented Dec 1, 2024

Description

This is a manual backport of #2024 (main) / #2029 (1.4) because 1.3 has different code style (prettier) rules and requires that the material-ui dependency be mentioned in the techdocs package.json.

1.3 without this PR:

1.3-before.mp4

with this PR (tested on a cluster with pr-2030-abfb8b96)

1-3-after-abfb8b96.mp4

Which issue(s) does this PR fix

  • Fixes RHDHBUGS-97 Bug in text selection in "Docs" section of RHDH
  • 1.3 ticket RHIDP-5121 Huge icon when techdoc text is selected, and report a doc issue feature didn't worked [1.3]

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Techdocs is enabled by default.

@christoph-jerolimov christoph-jerolimov self-assigned this Dec 1, 2024
@christoph-jerolimov christoph-jerolimov requested a review from a team as a code owner December 1, 2024 20:03
Copy link

openshift-ci bot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidfestal for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov christoph-jerolimov changed the title fix(techdocs): fix ReportIssue style issue when loaded as dynamic plugin fix(techdocs): fix ReportIssue style issue when loaded as dynamic plugin [release-1.3] Dec 1, 2024
Copy link
Contributor

github-actions bot commented Dec 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2030!

Copy link

sonarqubecloud bot commented Dec 1, 2024

Copy link
Contributor

github-actions bot commented Dec 1, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-2030!

@christoph-jerolimov
Copy link
Member Author

/retest

1 similar comment
@christoph-jerolimov
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Dec 2, 2024

@christoph-jerolimov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests abfb8b9 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@christoph-jerolimov
Copy link
Member Author

/override ci/prow/e2e-tests

Copy link

openshift-ci bot commented Dec 3, 2024

@christoph-jerolimov: christoph-jerolimov unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@christoph-jerolimov christoph-jerolimov merged commit 7039df0 into redhat-developer:release-1.3 Dec 3, 2024
6 of 8 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-techdocs-addons-1.3 branch December 3, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant