-
Notifications
You must be signed in to change notification settings - Fork 201
fix(techdocs): fix ReportIssue style issue when loaded as dynamic plugin [release-1.3] #2030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(techdocs): fix ReportIssue style issue when loaded as dynamic plugin [release-1.3] #2030
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
25ad510
to
012181c
Compare
The image is available at: |
Signed-off-by: Christoph Jerolimov <[email protected]>
012181c
to
abfb8b9
Compare
|
The image is available at: |
/retest |
1 similar comment
/retest |
@christoph-jerolimov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/override ci/prow/e2e-tests |
@christoph-jerolimov: christoph-jerolimov unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7039df0
into
redhat-developer:release-1.3
Description
This is a manual backport of #2024 (main) / #2029 (1.4) because 1.3 has different code style (prettier) rules and requires that the material-ui dependency be mentioned in the techdocs package.json.
1.3 without this PR:
1.3-before.mp4
with this PR (tested on a cluster with pr-2030-abfb8b96)
1-3-after-abfb8b96.mp4
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
Techdocs is enabled by default.