Skip to content

Conversation

Omar-AlJaljuli
Copy link
Contributor

Description

Disabling Tekton config and tests until namespace deletion fix is confirmed

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHIDP-4752

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Omar-AlJaljuli Omar-AlJaljuli requested a review from a team as a code owner October 31, 2024 20:20
@Omar-AlJaljuli
Copy link
Contributor Author

Recent merged PRs (fixes) by @gustavolira make this redundant.

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1867!

@Omar-AlJaljuli Omar-AlJaljuli reopened this Nov 8, 2024
Copy link
Member

@josephca josephca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

github-actions bot commented Nov 8, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1867!

Copy link

openshift-ci bot commented Nov 8, 2024

@Omar-AlJaljuli: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests ab0fb48 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot removed the lgtm label Nov 14, 2024
Copy link

openshift-ci bot commented Nov 14, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao closed this Nov 14, 2024
@nickboldt
Copy link
Member

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1867!

@nickboldt nickboldt reopened this Nov 14, 2024
@nickboldt nickboldt merged commit 65410ec into redhat-developer:1.2.x Nov 14, 2024
9 of 12 checks passed
Copy link

Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1867!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants