Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): added a workaround so that defaultProps are also picked up from MUI v5 components (like Button disabledRipple or Grid spacing) #204

Merged

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…p from MUI v5 components (like Button disabledRipple or Grid spacing)

Signed-off-by: Christoph Jerolimov <[email protected]>
@rhdh-gh-app
Copy link

rhdh-gh-app bot commented Dec 18, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-theme workspaces/theme/plugins/theme patch v0.4.7

Copy link
Contributor

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I wasn't able to reproduce the issue, but verified this solution doesn't break anything in local showcase 👍 Let's test out when the new version is out.

@openshift-ci openshift-ci bot added the lgtm label Dec 19, 2024
@ciiay ciiay merged commit 67de15b into redhat-developer:main Dec 19, 2024
7 checks passed
@christoph-jerolimov christoph-jerolimov deleted the fix-mui5-defaultprops branch December 19, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants