feat(global-header): initial PR for global header plugin #203
+39,204
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciiay
requested review from
BethGriggs,
nickboldt,
kim-tsao and
04kash
as code owners
ciiay
requested review from
christoph-jerolimov,
debsmita1 and
divyanshiGupta
Changed Packages
|
There was a problem hiding this comment.
Thanks, a great initial PR. 👍
Some small comments below and I think it's worthful if you can also address here:
- Add a line to .github/CODEOWNERs :)
- Please add a backstage app. I think its in general a good way to test plugins, but it's esp. useful for this plugin.
- Address my comments below and (optional if you really want do that in a follow-up PR, but I think there no reason to rush ;)) split the GlobalHeader file a bit and remove the examples components.
workspaces/global-header/plugins/global-header/src/components/GlobalHeader.tsx
Outdated
Show resolved
Hide resolved
workspaces/global-header/plugins/global-header/src/components/GlobalHeader.tsx
Outdated
Show resolved
Hide resolved
| <AppBar | ||
| position="sticky" | ||
| component="nav" | ||
| sx={{ backgroundColor: '#212427' }} |
There was a problem hiding this comment.
Fine for now, but can we have a story for reevaluating all the colors and the theme/customization support for the header.
There was a problem hiding this comment.
Right, we will make this configurable too. Also, do you think it's possible to use colors from our theme? Mui theme.palatte only have a few fields available, and most of our default colors from theme plugin aren't.
https://mui.com/material-ui/customization/palette/#customization
There was a problem hiding this comment.
Let me address theme issues in a different story as it could be more complex.
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
rhidp-5251-create-global-header-plugin
branch
from
65fbdaa to
81e7ead
Compare
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Initial PR for RHIDP-5251
✔️ Checklist
Screen recordings
plugins/global-header test
rhidp_5251.mp4
dev env test
rhidp_5251_dev.mp4