feat: Add workflow to auto-label workspace PRs #1400
+275
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Labels: workspace-update, workspace-addition, outside-workspaces, mandatory-workspace - Detects required plugins from downstream-plugins file - Runs daily at 6 AM UTC Assisted-by: Cursor
polasudo
requested review from
davidfestal,
gashcrumb and
kadel
as code owners
|
PR action ( |
davidfestal
requested changes
Sep 4, 2025
| const LABELS = { | ||
| UPDATE: 'workspace-update', | ||
| ADDITION: 'workspace-addition', | ||
| OUTSIDE: 'outside-workspaces', |
There was a problem hiding this comment.
Not a fan of the 'outside-workspaces' name.
|
|
||
| // Check if this is a new workspace | ||
| if (file.status === 'added') { | ||
| addedWorkspaces.add(workspace); |
There was a problem hiding this comment.
Is this test sufficient to know that it is the addition of a full workspace that didn't exist before ?
What happens if the PR only add a new file to an already-existing workspace (like a patch file in the /patches sub-folder) ?
davidfestal
requested changes
Sep 4, 2025
There was a problem hiding this comment.
BTW, I think we should also add another label related to the branch the PR is based on.
So we should also do the following changes:
- Add the
mandatory-workspacelabel only if the PR is based on the main branch - Add a release-branch-patch label on workspace PRs based on a release branch
Assisted-by: Cursor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assisted-by: Cursor