chore: RHIDP-1690: Fix SNYK findings #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreydaley
force-pushed
the
RHIDP-1690-fix-snyk-findings
branch
3 times, most recently
from
cb7b1b4
to
9f119d3
Compare
coreydaley
changed the title
coreydaley
force-pushed
the
RHIDP-1690-fix-snyk-findings
branch
from
356c0c2
to
fbaac54
Compare
|
coreydaley
changed the title
coreydaley
commented
Jun 12, 2024
coreydaley
commented
Jun 12, 2024
coreydaley
commented
Jun 12, 2024
coreydaley
commented
Jun 12, 2024
coreydaley
commented
Jun 12, 2024
rm3l
reviewed
Jun 14, 2024
coreydaley
force-pushed
the
RHIDP-1690-fix-snyk-findings
branch
from
fbaac54
to
a1f974a
Compare
coreydaley
force-pushed
the
RHIDP-1690-fix-snyk-findings
branch
from
a1f974a
to
de14ec2
Compare
rm3l
approved these changes
Jun 20, 2024
coreydaley
added a commit
to coreydaley/redhat-developer-rhdh-chart
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Updates the Helm chart to address issues identified by using the SNYK scanning tool, mostly updating the
securityContextsettings on the containers/pods to reduce the attach surface, and also adding requests/limits for the cpu and memory.Existing or Associated Issue(s)
Addresses https://issues.redhat.com/browse/RHIDP-1690
Additional Information
Checklist
Chart.yamlaccording to semver.values.yamland added to the README.md. The pre-commit utility can be used to generate the necessary content. Usepre-commit run -ato apply changes.pre-commithook.ct lintcommand.