-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create global cluster with rds cluster role #83
Conversation
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/test_create_rds_global_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
37168c1
to
4eeeee1
Compare
Waiting on ansible-collections/amazon.aws#1705 |
does it mean currently we can create Global database only in the same region? |
a121691
to
599cb0c
Compare
f87e1ec
to
fcaef26
Compare
There are a few ansible-lint issues that need to be addressed, but aside from those, the role functions properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few typos noted inline, but I also have a general comment about region. When I try to test this locally, it's picking up the aws region from test config in the Create a primary cluster for global database
step of create.yaml
, with a warning that Both option region and its alias aws_region are set
. I think we either need to pass aws_region
instead of region
to the calls to amazon.aws
modules, or we need to set the aws_region
variable explicitly to match region
. This will be an issue outside of testing for users if they have the AWS region set in ENV since the aws_setup_credentials
role pulls from that to set the aws_region
value.
Hmm. I'm running into the same issue when calling this role from the new high availability webapp playbook too. In that case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more comments otherwise this looks good!
SUMMARY
Continuing on PR #79
Add role
create_rds_global_cluster
to create aurora global cluster with two different region rds clusters.Currently, RDS resources created by role will be connect to
Default VPC
of thespecified region
.ISSUE TYPE
COMPONENT NAME
create_rds_global_cluster