Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awsconfig_apigateway_with_lambda_integration - new role #43

Merged
merged 3 commits into from
Aug 14, 2023
Merged

awsconfig_apigateway_with_lambda_integration - new role #43

merged 3 commits into from
Aug 14, 2023

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 26, 2023 •
edited
Loading

A Role to create an API gateway with Lambda proxy integration

@abikouo abikouo force-pushed the apigateway_lambda_v1 branch 5 times, most recently from c3d58f5 to 0bfb9d8 Compare July 11, 2023 14:51
@abikouo abikouo requested a review from gravesm July 11, 2023 16:33
@gravesm
Copy link
Member

gravesm commented Jul 19, 2023

This CI for this still appears to be broken.

@abikouo
Copy link
Contributor Author

abikouo commented Jul 19, 2023

This CI for this still appears to be broken.

@gravesm CI issue is unrelated to this PR, the fixing PR is #52

@abikouo abikouo force-pushed the apigateway_lambda_v1 branch from 0bfb9d8 to 7f72c9b Compare July 26, 2023 06:07
@abikouo
Copy link
Contributor Author

abikouo commented Jul 26, 2023

@gravesm CI is failing not as I was expecting, this is due to #44 which has been merged without tests
I have created #67 to fix that, however since we are not running on the pull request head branch this may still failed until we fix it

@abikouo abikouo force-pushed the apigateway_lambda_v1 branch from ffb6b43 to e1c1632 Compare July 27, 2023 07:12
@abikouo abikouo requested a review from gravesm July 27, 2023 15:21
@abikouo
Copy link
Contributor Author

abikouo commented Jul 28, 2023

Please note that the following PR ansible-collections/community.aws#1845 has be merged first for the CI to pass.

gravesm
gravesm reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests are still failing. It seems you are trying to use options on the api_gateway module that do not exist.

@abikouo abikouo closed this Aug 1, 2023
@abikouo abikouo reopened this Aug 1, 2023
@abikouo abikouo force-pushed the apigateway_lambda_v1 branch from 9d44df2 to a1407e3 Compare August 2, 2023 09:55
@abikouo abikouo requested a review from gravesm August 2, 2023 09:55
@abikouo abikouo force-pushed the apigateway_lambda_v1 branch from 2d33ff2 to f1a4e6f Compare August 2, 2023 10:12
@abikouo abikouo force-pushed the apigateway_lambda_v1 branch from f1a4e6f to 6fbd416 Compare August 14, 2023 07:17
@abikouo abikouo merged commit 99bac88 into redhat-cop:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
safe to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abikouo @gravesm @alinabuzachis