Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new ec2_instance_create role #123
base: main
Are you sure you want to change the base?
Add new ec2_instance_create role #123
Changes from 13 commits
8d65950
b36ce1e
ad9e560
0fcb621
aec04dc
8e4aa21
a1c5631
e940702
88b5223
74ee704
0d81188
1d7bf6e
d7b8b80
c8aa0d3
dad97f8
e8cf01f
162ac4a
68b0fe6
6a8ff47
b82fc7c
33f839e
84cfeae
35a2670
05d4573
2f68c4b
ec7de80
ca18ea3
5c272d9
e464689
839b993
a913112
be8de82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if it is stated in the ticket that the key name should be required this should be set as optional for 2 reasons:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter can be also optional as the instance can be created in the default subnet id if it exists