Fix test failures in deploy_flask_app and backup_select_resources roles #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,7 +126,7 @@ To delete the webapp: | |||
| * **rds_instance_class** (str): DB instance class for the RDS instance. Default: `db.m6g.large` | |||
| * **rds_instance_name** (str): Name for the database. Default: `mysampledb123` | |||
| * **rds_engine** (str): Engine to use for the database. Default: `postgres` | |||
| * **rds_engine_version** (str): Version number of the database engine to use. Default: `"14.8"` | |||
| * **rds_engine_version** (str): Version number of the database engine to use. Default: `"16.2"` | |||
There was a problem hiding this comment.
Is this change a breaking_change?
There was a problem hiding this comment.
I fail to see why this modification would constitute a breaking change. AWS has eliminated the 14.8 version. Users can still specify the desired version number as they did previously. If not specified, the default value will now be 16.2 instead of 14.8. This adjustment should have no impact on users of this role. Does this make sense to you?
alinabuzachis
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the integration test failures for the following roles
deploy_flask_app:
The Postgres DB engine version 14.8 has been removed and replaced with version 16.2.
backup_select_resources:
Incorrect mention of a dict attribute has been rectified with the right one