Improve environment variable handling #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jduimovich PTAL |
chmeliik
force-pushed
the
improve-env-handling
branch
from
913da0b
to
730efb8
Compare
They drifted. Minimize the differences to the expected ones: - the lines with placeholder variables - the REKOR_HOST and TUF_MIRROR variables which allow overrides in env.sh but not in env.template.sh Update the related sed command in *-pipeline.sh accordingly. Signed-off-by: Adam Cmiel <[email protected]>
* Previously, it was impossible to set the variables to an empty string.
Use ${var-default} instead of ${var:-default} to allow it.
* Replace 'none' in the documentation with ''.
* Drop the MY_ prefix from the override variables, simply respect the
Actual variables if they're set.
* Align this between env.sh and env.template.sh.
* Drop the sed command that is no longer needed in *-pipeline.sh
* Allow to override IGNORE_REKOR as well.
Signed-off-by: Adam Cmiel <[email protected]>
This effectively changes the purpose of env.sh: instead of overwriting every relevant environment variable, it only sets default values for those that are unset. Previously, it was impossible to set environment variables any other way than by editing env.sh. Now, it will be possible to set environment variables the standard way. Signed-off-by: Adam Cmiel <[email protected]>
Previously, it considered variables that were set to an empty string as undefined. This made it impossible to skip optional features (those that can be skipped by setting the relevant variables to empty strings). Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
improve-env-handling
branch
from
730efb8
to
4cab8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the environment variable handling confusing and hard to work with. This is an attempt to improve it.
See the individual commits for more details