disable namespace-lister's group support in prod

[filariow]

Requires:

• disable namespace-lister's group support in stg #7924

We don't want to return the list of all namespaces shared with the system:authenticated group (the only group supported nowadays).

We just want to show the list of namespaces directly shared with the user.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[github-actions]

Code Review by Gemini

The changes disable the with_header_auth_groups.yaml patch in both the base and production Kustomization configurations by commenting it out. This aligns with the commit message's intent to prevent listing namespaces based on group membership (specifically system:authenticated) and instead focus on namespaces directly shared with the user.

There are no bugs or issues with this change. The approach of commenting out the patch is a valid way to disable it in Kustomize, and the added comments provide good context for future maintainers.

--- a/components/namespace-lister/base/kustomization.yaml
+++ b/components/namespace-lister/base/kustomization.yaml
@@ -19,16 +19,19 @@ patches:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
 - path: ./patches/with_header_auth_user.yaml
   target:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
-- path: ./patches/with_header_auth_groups.yaml
-  target:
-    group: apps
-    kind: Deployment
-    name: namespace-lister
-    namespace: namespace-lister
+# uncomment this line to add support for groups forwarded through
+# a custom header
+#
+# - path: ./patches/with_header_auth_groups.yaml
+#   target:
+#     group: apps
+#     kind: Deployment
+#     name: namespace-lister
+#     namespace: namespace-lister

--- a/components/namespace-lister/production/base/kustomization.yaml
+++ b/components/namespace-lister/production/base/kustomization.yaml
@@ -19,16 +19,19 @@ patches:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
 - path: ./patches/with_header_auth_user.yaml
   target:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
-- path: ./patches/with_header_auth_groups.yaml
-  target:
-    group: apps
-    kind: Deployment
-    name: namespace-lister
-    namespace: namespace-lister
+# uncomment this line to add support for groups forwarded through
+# a custom header
+#
+# - path: ./patches/with_header_auth_groups.yaml
+#   target:
+#     group: apps
+#     kind: Deployment
+#     name: namespace-lister
+#     namespace: namespace-lister

[hugares]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• components/namespace-lister/OWNERS [filariow,hugares]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[github-actions]

Code Review by Gemini

The changes correctly disable the with_header_auth_groups.yaml patch by commenting out the relevant lines in kustomization.yaml. This aligns with the commit message's intent to disable group support in production.

No bugs or issues were found. The added comment provides clear instructions for future maintainers if the feature needs to be re-enabled.

--- a/components/namespace-lister/production/base/kustomization.yaml
+++ b/components/namespace-lister/production/base/kustomization.yaml
@@ -19,16 +19,19 @@ patches:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
 - path: ./patches/with_header_auth_user.yaml
   target:
     group: apps
     kind: Deployment
     name: namespace-lister
     namespace: namespace-lister
-- path: ./patches/with_header_auth_groups.yaml
-  target:
-    group: apps
-    kind: Deployment
-    name: namespace-lister
-    namespace: namespace-lister
+# uncomment this line to add support for groups forwarded through
+# a custom header
+#
+# - path: ./patches/with_header_auth_groups.yaml
+#   target:
+#     group: apps
+#     kind: Deployment
+#     name: namespace-lister
+#     namespace: namespace-lister

[filariow]

/hold