-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVAI-157: Pull latest updates from ai-lab-recipes #13
Conversation
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ before approval - Are the changes to the Containerfiles
and requirements.txt
changes that we hadn't previously pulled in? I know they weren't included in your upstream pr
Yes I think they have renovate enabled in their repo (I'd suggest doing the same with our images repo btw). See containers/ai-lab-recipes@65a7ffe for example. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/hold Until proper testing is completed for DEVAI-158 |
Singed-off-by: thepetk <[email protected]>
@maysunfaisal @Jdubrick I've updated the PR with the latest changes of the recipes containers/ai-lab-recipes#799. Thorough testing has been made here: redhat-ai-dev/ai-lab-app#28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What does this PR do?:
Simply pulls all latest updates made in
containers/ai-lab-recipes
, after the merge of containers/ai-lab-recipes#790Which issue(s) this PR fixes:
DEVAI-157
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
Tested and Verified
Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
How to test changes / Special notes to the reviewer: