Configure mypy skip following imports for some dependencies to workaround bugs #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for issues such as python/mypy#13499 in the version of mypy version we're currently using which are causing spurious type checking failures. These workarounds should be removed when we bump the mypy version to one without these bugs.
|
Is this an issue with |
|
the change is needed when mypy is installed with a python version >3.8, but because of the linked bug reports spurious failures in stub files |
whyitfor
reviewed
Jan 8, 2025
|
The bug this workaround is needed for was fixed in mypy version 0.981. This change should be reverted after mypy to that version or later in the future. Tracked in #550 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored by @Jepson2k
Workaround for issues such as python/mypy#13499
in the version of mypy version we're currently using which are causing
spurious type checking failures.
These workarounds should be removed when we bump the mypy version to
one without these bugs.
One sentence summary of this PR (This should go in the CHANGELOG!)
Configure mypy skip following imports for some dependencies to workaround bugs.
Link to Related Issue(s)
#550
Please describe the changes in your request.
Add
follow_imports = skiptotempfile312,liefandnumpyto workaround mypy bugs causing spurious type checking failures.Anyone you think should look at this, specifically?