Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix model mesh tests and update runtime images (#2060) #2076

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fix model mesh tests and update runtime images (#2060) #2076

merged 1 commit into from
Nov 28, 2024

Conversation

tarukumar
Copy link
Contributor

@tarukumar tarukumar commented Nov 27, 2024 •
edited
Loading

No description provided.

@rnetser
Fix model mesh tests and update runtime images (#2060)
8cfdd75 
* Update model mesh deploymenet from ui

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* add raw and serverless

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* add raw and serverless

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* fix tests

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* fix tests

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* fix tests

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* update images

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* fix tests and code

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* use cli project deletion

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* use cli project deletion

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

* remove parenthasis

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
@@ -226,7 +226,7 @@
[Arguments] ${model_name}
# TODO: Open model serving home page if needed?
# Click on Inference Endpoints link
${endpoint_link}= Set Variable //a[@data-testid="metrics-link-test-model" and text()="${model_name}"]/ancestor::tr//td//button[@data-testid="internal-external-service-button"]
${endpoint_link}= Set Variable //a[contains(@data-testid, 'metrics-link')][text() = '${model_name}']/ancestor::tr//td//button[@data-testid="internal-external-service-button"]

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (184/120)
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
@@ -426,6 +427,7 @@
Sleep 1s
END
Switch Model Serving Project project_name=All projects
@{projects}= Get WebElements xpath://table/tbody/tr/td[@data-label="Project"]

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '@{projects}' is assigned but not used
ods_ci/tests/Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
Page Should Contain Element xpath://span[contains(., "${runtime}")]
${selected}= Run Keyword And Return Status
... Click Element xpath://span[contains(., "${runtime}")]
IF ${selected}==${TRUE} BREAK

Check notice

Code scanning / Robocop

'{{ block_name }}' condition can be simplified Note test

'INLINE IF' condition can be simplified
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (141/120)
ods_ci/tests/Tests/1000__model_serving/1001__model_serving_modelmesh.robot
... existing_data_connection=${TRUE} data_connection_name=model-serving-connection
... model_path=inception_resnet_v2.pb
${runtime_pod_name}= Replace String Using Regexp string=${RUNTIME_NAME} pattern=\\s replace_with=-
${runtime_pod_name}= Convert To Lower Case ${runtime_pod_name}
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME}
Wait Until Keyword Succeeds 5 min 10 sec Verify Serving Service
Wait Until Keyword Succeeds 5 min 10 sec Verify Openvino Deployment runtime_name=${RUNTIME_POD_NAME} project_name=${namespace}

Check warning

Code scanning / Robocop

Variable '{{ name }}' has inconsistent naming. First used as '{{ first_use }}' Warning test

Variable '${RUNTIME_POD_NAME}' has inconsistent naming. First used as '${runtime_pod_name}'
ods_ci/tests/Tests/1000__model_serving/1005__model_serving_ovms_on_kserve.robot
@@ -64,10 +64,10 @@
Verify Model Status ${MODEL_NAME} success
Set Suite Variable ${MODEL_CREATED} ${TRUE}
${url}= Get Model Route Via UI ${MODEL_NAME}
${status_code} ${response_text}= Send Random Inference Request endpoint=${url} name=input
${status_code} ${response_text}= Send Random Inference Request endpoint=${url} name=input:0

Check notice

Code scanning / Robocop

Variable '{{ name }}' is assigned but not used Note test

Variable '${response_text}' is assigned but not used
ods_ci/tests/Tests/1000__model_serving/1008_model_serving_cross_auth.robot
@@ -68,7 +68,7 @@
... token_auth=${TRUE} token=${first_token}
Run Keyword And Warn On Failure Should Contain ${inf_out} Log in with OpenShift
[Teardown] Run Keywords Run Keyword If Test Failed Get Kserve Events And Logs
... model_name=${MODEL_NAME} project_title=${PRJ_TITLE} AND Clean All Models Of Current User
... model_name=${MODEL_NAME} project_title=${PRJ_TITLE} AND model_name=${SECOND_MODEL_NAME} project_title=${PRJ_TITLE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (137/120)
ods_ci/tests/Tests/1000__model_serving/1008_model_serving_cross_auth.robot
@@ -68,7 +68,7 @@
... token_auth=${TRUE} token=${first_token}
Run Keyword And Warn On Failure Should Contain ${inf_out} Log in with OpenShift
[Teardown] Run Keywords Run Keyword If Test Failed Get Kserve Events And Logs
... model_name=${MODEL_NAME} project_title=${PRJ_TITLE} AND Clean All Models Of Current User
... model_name=${MODEL_NAME} project_title=${PRJ_TITLE} AND model_name=${SECOND_MODEL_NAME} project_title=${PRJ_TITLE}

Check warning

Code scanning / Robocop

Underscores in keyword name '{{ keyword_name }}' can be replaced with spaces Warning test

Underscores in keyword name 'model_name=${SECOND_MODEL_NAME}' can be replaced with spaces
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -54,7 +54,7 @@
Recreate S3 Data Connection project_title=${PRJ_TITLE} dc_name=model-serving-connection
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${TRUE}
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${FALSE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
...erving/1010__model_serving_triton_on_modelmesh/1010__model_serving_triton_on_modelmesh.robot
@@ -130,7 +130,7 @@
Recreate S3 Data Connection project_title=${PRJ_TITLE} dc_name=model-serving-connection
... aws_access_key=${S3.AWS_ACCESS_KEY_ID} aws_secret_access=${S3.AWS_SECRET_ACCESS_KEY}
... aws_bucket_name=ods-ci-s3
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${TRUE}
Create Model Server token=${TRUE} runtime=${ONNX_RUNTIME_NAME} server_name=${ONNX_RUNTIME_NAME} existing_server=${FALSE}

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test

Line is too long (136/120)
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
579 0 0 579 100

@tarukumar tarukumar enabled auto-merge (squash) November 27, 2024 14:02
@rnetser
Copy link
Contributor

rnetser commented Nov 27, 2024

/lgtm

aloganat
aloganat approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tarukumar tarukumar merged commit ad29b53 into releases/2.16.0 Nov 28, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloganat aloganat aloganat approved these changes

@mwaykole mwaykole mwaykole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tarukumar @rnetser @aloganat @mwaykole