Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dsp post upgrade. Add keyword "Skip If Operator Starting Version Is Not Supported" #2073

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Fix dsp post upgrade. Add keyword "Skip If Operator Starting Version Is Not Supported" #2073

merged 6 commits into from
Nov 26, 2024

Conversation

jgarciao
Copy link
Contributor

  • Adds keyword Skip If Operator Starting Version Is Not Supported based on previous work by @lugi0
  • Sets minimum starting version for pipelines post-upgrade verification
  • In pipeline post-upgrade verification, accept RUNNING and SUCCEEDED state when checking the status of the test pipeline

@jgarciao jgarciao added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels Nov 25, 2024
@jgarciao
Copy link
Contributor Author

Tested successfully in rhoai-test-flow/1742

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
577 0 0 577 100

FedeAlonso
FedeAlonso previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@FedeAlonso FedeAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. LGTM

@jgarciao
Use new kw for model registry
e23b6fe 
Signed-off-by: Jorge Garcia Oncins <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lugi0
lugi0 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@lugi0 lugi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements, LGTM

@jgarciao jgarciao merged commit ccf4143 into red-hat-data-services:master Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdattoma bdattoma bdattoma approved these changes

@lugi0 lugi0 lugi0 approved these changes

@diegolovison diegolovison Awaiting requested review from diegolovison

@FedeAlonso FedeAlonso Awaiting requested review from FedeAlonso

Assignees
No one assigned
Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgarciao @FedeAlonso @lugi0 @bdattoma