Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Operator DSC Workbenches Component Tests #2072

Merged

Conversation

mattmahoneyrh
Copy link
Contributor

New Operator DSC Workbenches component test cases which validate that Workbenches resources are created/destroyed as expected.

@mattmahoneyrh mattmahoneyrh added needs testing Needs to be tested in Jenkins new test New test(s) added (PR will be listed in release-notes) labels Nov 25, 2024
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
579 0 0 579 100

@mattmahoneyrh mattmahoneyrh added verified This PR has been tested with Jenkins and removed needs testing Needs to be tested in Jenkins labels Nov 25, 2024
CFSNM
CFSNM previously approved these changes Nov 26, 2024
Copy link
Contributor

@CFSNM CFSNM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mattmahoneyrh for adding this. With these tests, I think we are covering all components happy paths

Copy link
Contributor

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, feel free to skip it. LGTM and thanks!

@mattmahoneyrh mattmahoneyrh merged commit 9b3453e into red-hat-data-services:master Nov 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new test New test(s) added (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants