Merge pull request #47 from hatappi/fix/marshal-dump-save_file

MarshalSerializer.save_file receives string file_path

lib/chainer/serializers/marshal.rb

@@ -3,10 +3,14 @@ module Serializers
     class MarshalSerializer < Chainer::Serializer      
       attr_accessor :target, :path
 
-      def self.save_file(filename, obj)
+      # @param [string] file_path Target file path
+      # @param [Object] obj Object to be serialized
+      def self.save_file(file_path, obj)
         s = self.new
         s.save(obj)
-        Marshal.dump(s.target, filename)
+        File.open(file_path, 'wb') do |f|
+          Marshal.dump(s.target, f)
+        end
       end
 
       def initialize(target: nil, path: "")

lib/chainer/training/extensions/snapshot.rb

@@ -23,7 +23,7 @@ def call(trainer)
           filename = filename_proc.call(trainer)
           prefix = "tmp#{filename}"
           temp_file = Tempfile.create(basename: prefix, tmpdir: trainer.out)
-          save_class.save_file(temp_file, trainer)
+          save_class.save_file(temp_file.path, trainer)
           FileUtils.move(temp_file.path, File.join(trainer.out, filename))
         end
       end