[CodeQuality] Skip loose compare string on AssertEqualsToSameRector (#…

…435)
rectorphp · Dec 25, 2024 · 918b33b · 918b33b
1 parent 531ce02
commit 918b33b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/...lity/Rector/MethodCall/AssertEqualsToSameRector/Fixture/skip_loose_compare_string.php.inc b/...lity/Rector/MethodCall/AssertEqualsToSameRector/Fixture/skip_loose_compare_string.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertEqualsToSameRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipLooseCompareString extends TestCase
+{
+    public function test()
+    {
+        $this->assertEquals(1, '1');
+    }
+}
diff --git a/rules/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector.php b/rules/CodeQuality/Rector/MethodCall/AssertEqualsToSameRector.php
@@ -108,11 +108,11 @@ public function refactor(Node $node): ?Node
             $secondArgType = TypeCombinator::removeNull($this->nodeTypeResolver->getNativeType($args[1]->value));
 
             // loose comparison
-            if ($firstArgType instanceof IntegerType && $secondArgType instanceof FloatType) {
+            if ($firstArgType instanceof IntegerType && ($secondArgType instanceof FloatType || $secondArgType instanceof StringType)) {
                 return null;
             }
 
-            if ($firstArgType instanceof FloatType && $secondArgType instanceof IntegerType) {
+            if ($firstArgType instanceof FloatType && ($secondArgType instanceof IntegerType || $secondArgType instanceof StringType)) {
                 return null;
             }