Fix/272 Strict phpunit10 feature for php 81 (#289)

Co-authored-by: Erison Silva <[email protected]>
rectorphp · Nov 7, 2023 · 7978595 · 7978595
1 parent 6903fc7
commit 7978595
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php b/rules/AnnotationsToAttributes/Rector/ClassMethod/DataProviderAnnotationToAttributeRector.php
@@ -16,7 +16,7 @@
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
-use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\Core\ValueObject\PhpVersion;
 use Rector\PhpAttribute\NodeFactory\PhpAttributeGroupFactory;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -82,7 +82,13 @@ public function getNodeTypes(): array
 
     public function provideMinPhpVersion(): int
     {
-        return PhpVersionFeature::ATTRIBUTES;
+        /**
+         * This rule just work for phpunit 10,
+         * And as php 8.1 is the min version supported by phpunit 10, then we decided to let this version as minimum.
+         *
+         * You can see more detail in this issue: https://github.com/rectorphp/rector-phpunit/issues/272
+         */
+        return PhpVersion::PHP_81;
     }
 
     /**

diff --git a/src/Rector/StmtsAwareInterface/WithConsecutiveRector.php b/src/Rector/StmtsAwareInterface/WithConsecutiveRector.php
@@ -22,7 +22,7 @@
 use PhpParser\NodeTraverser;
 use Rector\Core\PhpParser\Node\BetterNodeFinder;
 use Rector\Core\Rector\AbstractRector;
-use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\Core\ValueObject\PhpVersion;
 use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -125,7 +125,13 @@ public function refactor(Node $node)
 
     public function provideMinPhpVersion(): int
     {
-        return PhpVersionFeature::MATCH_EXPRESSION;
+        /**
+         * This rule just work for phpunit 10,
+         * And as php 8.1 is the min version supported by phpunit 10, then we decided to let this version as minimum.
+         *
+         * You can see more detail in this issue: https://github.com/rectorphp/rector-phpunit/issues/272
+         */
+        return PhpVersion::PHP_81;
     }
 
     /**