Skip to content

Commit

Permalink
[SYCL][Doc] Rephrase "recording to"
Browse files Browse the repository at this point in the history
[Review feedback](intel#5626 (comment))
questioned the phrase "graph is currently being recorded to" as to
whether "to" should be "too". I don't think it should be "too", but
rephrasing to "graph is currently recording any queues" avoids any
confusion.

Also updated the contributors to add Maxime and Jaime (who made the
comment).
  • Loading branch information
EwanC committed Jul 12, 2023
1 parent 498686c commit 7e97438
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ Guo Yejun, Intel +
Dan Holmes, Intel +
Greg Lueck, Intel +
Steffen Larsen, Intel +
Jaime Arteaga Molina, Intel +
Ewan Crawford, Codeplay +
Ben Tracy, Codeplay +
Duncan McBain, Codeplay +
Expand All @@ -50,6 +51,7 @@ Gordon Brown, Codeplay +
Erik Tomusk, Codeplay +
Bjoern Knafla, Codeplay +
Lukas Sommer, Codeplay +
Maxime France-Pillois, Codeplay +
Ronan Keryell, AMD +

== Dependencies
Expand Down Expand Up @@ -169,13 +171,13 @@ what data is internal to the graph for optimization, and dependencies don't need
to be inferred.

It is valid to combine these two mechanisms, however it is invalid to modify
a graph using the explicit API while that graph is currently being recorded to,
for example:
a graph using the explicit API while that graph is currently recording commands
from any queue, for example:

[source, c++]
----
graph.begin_recording(queue);
graph.add(/*command group*/); // Invalid as graph is being recorded to
graph.add(/*command group*/); // Invalid as graph is recording a queue
graph.end_recording();
----

Expand Down

0 comments on commit 7e97438

Please sign in to comment.