Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open edge context menu from label click #266

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

nimaadarga
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently in order to open the context menu on an edge you have to click the actual edge itself even if a label is present.

Issue Number: N/A

What is the new behavior?

The edge context menu can be opened when clicking on the label text as well as the edge itself, similar to the existing behaviour for nodes.

Screen.Recording.2024-08-27.at.13.48.51.mov

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit f3e7b25
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66cdcfa941826d000893fb27
😎 Deploy Preview https://deploy-preview-266--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl requested a review from ghsteff August 27, 2024 13:13
Copy link
Contributor

@ghsteff ghsteff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@amcdnl amcdnl merged commit bd23e1a into reaviz:master Aug 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants