Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jerky layout switching #238

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix jerky layout switching #238

merged 1 commit into from
Apr 30, 2024

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Apr 30, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Graphs sometimes fly to entirely different locations when switching the layout type

What is the new behavior?

Different graph layouts stay centered on the same origin

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This centers all graph simulations on (0,0) so they don't fly across the view when you switch the layout

BEFORE

Screen.Recording.2024-04-30.at.12.42.33.PM.mov

AFTER

Screen.Recording.2024-04-30.at.12.42.01.PM.mov

This centers all graph simulations on (0,0) so they don't fly across the view when you switch the layout
@ghsteff ghsteff requested a review from amcdnl April 30, 2024 17:45
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit 6a0e89f
🔍 Latest deploy log https://app.netlify.com/sites/reagraph/deploys/66312e438c3dab0008e3ee2f
😎 Deploy Preview https://deploy-preview-238--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amcdnl amcdnl merged commit 54a753d into master Apr 30, 2024
5 checks passed
@amcdnl amcdnl deleted the fix/Jerky-layout-switching branch April 30, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants