Fix eslint setup #236
Merged
Fix eslint setup #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amcdnl
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
What is the current behavior?
eslint was not running properly in VSCode Windows. Missing target source directory in package.json was preventing linter from finding issues. After fixing that got warning about missing react version in eslint config. This is fixed in PR as well
What is the new behavior?
Works fine for my setup (VS Code on Windows). If error is introduced 'npm run' lint correctly identifies it
Does this PR introduce a breaking change?
No, but could affect build actions.