Fix camera view resetting on label visibility change #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the automatic centering behavior whenever the nodes array updates The labelVisible field within a node was causing issues when it updated because it would cause a re-render that would trigger the camera to re-center Centering the camera is now left to be handled on a case-by-case basis using the centerGraph method from GraphCanvasRef
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was
linked to
issues
Apr 3, 2024
amcdnl
reviewed
Apr 4, 2024
| @@ -178,12 +178,6 @@ export const useCenterGraph = ({ | |||
| // Center the graph once nodes are loaded on mount | |||
| await centerNodes(nodes, { animated: false }); | |||
| mounted.current = true; | |||
| } else { | |||
There was a problem hiding this comment.
Wait - so now it won't auto center?
There was a problem hiding this comment.
It still auto centers on selection and mount, but not whenever nodes change. I was thinking about something like a deep compare to only trigger the centering if one of the node.position's changed, but then dragging while zoomed is still an issue.
The dragging issue makes this feel hard enough to predict when or when not to re-center that I figured leaving it to be handled outside the canvas was the safest move
amcdnl
requested changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The camera resets while zooming in on a big graph when label visibility switches
The camera also resets while dragging nodes when other nodes are out view.
Issue Number: #213 #214
What is the new behavior?
The camera doesn't re-center automatically when nodes/labels update. Centering the camera is now left to be handled on a case-by-case basis using the
centerGraphmethod fromGraphCanvasRefDoes this PR introduce a breaking change?
Other information
The
node.labelVisiblefield was triggering a re-render when it updated that would cause the camera to re-center if any nodes were out of view. Same thing was happening when dragging a node which updatesnode.positionBEFORE
Screen.Recording.2024-04-03.at.12.55.48.PM.mov
AFTER
Screen.Recording.2024-04-03.at.12.54.28.PM.mov