Fix graph only centering when nodes out of view #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ideally I would have made a change here like but you can’t use the |
amcdnl
approved these changes
Mar 19, 2024
amcdnl
reviewed
Mar 19, 2024
src/GraphScene.tsx
Outdated
| @@ -233,7 +233,7 @@ export interface GraphSceneRef { | |||
| /** | |||
| * Center the graph on a node or list of nodes. | |||
| */ | |||
| centerGraph: (ids?: string[]) => void; | |||
| centerGraph: (ids?: string[], centerIfNodesNotInView?: boolean) => void; | |||
There was a problem hiding this comment.
We need ot add some docs to this new arg.
amcdnl
reviewed
Mar 19, 2024
amcdnl
reviewed
Mar 19, 2024
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
amcdnl
reviewed
Mar 22, 2024
src/GraphCanvas.tsx
Outdated
| @@ -120,7 +121,14 @@ export const GraphCanvas: FC<GraphCanvasProps & { ref?: Ref<GraphCanvasRef> }> = | |||
| const canvasRef = useRef<HTMLCanvasElement | null>(null); | |||
|
|
|||
| useImperativeHandle(ref, () => ({ | |||
| centerGraph: (n?: string[]) => rendererRef.current?.centerGraph(n), | |||
| centerGraph: ({ | |||
There was a problem hiding this comment.
I probably would have made nodes the first arg and then all the others a options arg. This makes it a non-breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The graph will only center if a node is out of view, even when trying to center manually from a control button
What is the new behavior?
The graph centers when triggering manually with controls
Does this PR introduce a breaking change?
Other information
BEFORE
Screen.Recording.2024-03-19.at.12.05.28.PM.mov
AFTER
Screen.Recording.2024-03-19.at.12.04.49.PM.mov