Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix can't zoom while hovering a node #205

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

ghsteff
Copy link
Contributor

@ghsteff ghsteff commented Mar 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

You can't zoom the camera while hovering a node

What is the new behavior?

You can zoom while hovering a node

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The camera controls were being entirely disabled while hovering a node. Set the truckSpeed to 0 instead ("Speed of drag for truck and pedestal")

@ghsteff ghsteff requested a review from amcdnl March 13, 2024 22:32
Copy link
Member

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It almost looks like it was done on purpose. Not sure I remember why 😂

@ghsteff
Copy link
Contributor Author

ghsteff commented Mar 13, 2024

It almost looks like it was done on purpose. Not sure I remember why 😂

I recently moved this camera controls disable from "on drag" to "on hover", so it was me 😁

but now that you mention, this change means you can do stuff like zoom while dragging a node. That seems fine right?

@amcdnl amcdnl merged commit bd80b79 into master Mar 14, 2024
1 check passed
@amcdnl amcdnl deleted the fix/zoom-while-hovering branch March 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants