Fix 2d graph over-rotating on node select #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amcdnl
reviewed
Mar 5, 2024
| /** | ||
| * Get the closest axis to a given angle. | ||
| */ | ||
| export function getClosestAxis(angle: number, axes: number[]) { |
amcdnl
reviewed
Mar 5, 2024
| /** | ||
| * Get how far an angle is from the closest 2D axis in radians. | ||
| */ | ||
| export function getDegreesToClosest2dAxis( |
amcdnl
reviewed
Mar 5, 2024
| @@ -71,7 +71,13 @@ export const useCenterGraph = ({ | |||
|
|
|||
| // Check whether the layout is 3d or not to adjust centering logic | |||
| if (!layoutType.includes('3d')) { | |||
| void controls?.rotateTo(0, Math.PI / 2, true); | |||
| const { horizontalRotation, verticalRotation } = | |||
There was a problem hiding this comment.
Let's add a description on what this is/why
amcdnl
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
2d graphs over-rotate sometimes when selecting or de-selecting a node
Issue Number: #192
What is the new behavior?
2d graphs will rotate to the closest flat axis on node selection
Does this PR introduce a breaking change?
Other information
BEFORE
Screen.Recording.2024-03-05.at.2.54.53.PM.mov
AFTER
Screen.Recording.2024-03-05.at.2.58.08.PM.mov