Fix 2D rotation on centering #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rotates 2d graphs properly when centering so they don't rotate to the incorrect axis when it's closer
ghsteff
commented
Feb 26, 2024
Comment on lines
+72
to
+74
| if (!layoutType.includes('3d')) { | ||
| void controls?.rotateTo(0, Math.PI / 2, true); | ||
| } |
There was a problem hiding this comment.
This feels a little flaky and not so obvious if we were to add more layout types. It is simple tho 🤔
amcdnl
reviewed
Feb 26, 2024
amcdnl
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Centering a 2d graph after rotating locks to the wrong axis when it's the closest
What is the new behavior?
2d graphs rotate to the correct axis when centering
Does this PR introduce a breaking change?
Other information
BEFORE
Screen.Recording.2024-02-26.at.1.02.02.PM.mov
Screen.Recording.2024-02-26.at.1.01.45.PM.mov
AFTER
Screen.Recording.2024-02-26.at.1.00.01.PM.mov
Screen.Recording.2024-02-26.at.1.01.21.PM.mov