Hide labels based off distance from camera #187
Conversation
This hides labels when they're so far away from the camera you can't read them anyway labels have a big impact on performance when there's enough of them
| isCentered && ( | ||
| <Fragment> | ||
| {nodeComponents} | ||
| {edgeComponents} | ||
| {clusterComponents} | ||
| </Fragment> | ||
| ) |
There was a problem hiding this comment.
This could make more sense named mounted, but that's also not exactly what it is
isCentered is true when the camera re-orients from it's initial z position of 1000, which happens on big graphs
Without this the label visibility calculation is usually off on the initial render
There was a problem hiding this comment.
This also gets rid of that laggy zoom out/jump on initial big graph renders which I think was previously being handled here with a mounted && ...
|
This doesn't hide edge labels. Edges don't have a position so we'd prob grab either the source or target node to decide whether to show the label I can add hiding edge labels to this PR or a follow up |
src/CameraControls/useCenterGraph.ts
Outdated
| @@ -41,6 +41,8 @@ export const useCenterGraph = ({ | |||
| disabled | |||
| }: CenterGraphInput): CenterGraphOutput => { | |||
| const nodes = useStore(state => state.nodes); | |||
| const isCentered = useStore(state => state.isCentered); | |||
There was a problem hiding this comment.
You don't need to put this in the store based on the current useage, u could just return in state.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Labels show on every node even when there so small they're unreadable. This can have a big impact on performance
What is the new behavior?
Labels don't render when they're so small they can't be read. This is based off zoom and distance from camera
Does this PR introduce a breaking change?
Other information
BEFORE
Untitled.mov
AFTER
Screen.Recording.2024-02-22.at.6.50.37.PM.mov
Screen.Recording.2024-02-22.at.6.49.59.PM.mov